-
Notifications
You must be signed in to change notification settings - Fork 20
BECKHOFF minimal example motor #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please fix the checks and do an rebase. |
|
fixed it |
912b096 to
ca80909
Compare
kraemr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all your .idea stuff you committed, stuff like this should never end up in a branch!
|
@kraemr we should add .idea to the gitignore |
|
He should |
|
@TheBest6337 please fix and merge this finally. We need the Motor example done. |
783dc37 to
ad05f82
Compare
TheBest6337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge Conflicts and other issues are fixed @Oshgnacknak i need your final review ^^
Oshgnacknak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still is some German left
electron/src/machines/motor_test_machine/TestMotorControlPage.tsx
Outdated
Show resolved
Hide resolved
|
@Oshgnacknak can you take this issue over and finish it? |
|
@TheBest6337 pls finish this, this should be 5 minutes - we need it for the docs and videos. |
…off Ek1100 and EL7031 # Conflicts: # machines/src/aquapath1/act.rs # machines/src/registry.rs # server/src/ethercat/setup.rs
1ad4337 to
1d71258
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a comprehensive minimal example for integrating a Beckhoff EL7031-0030 stepper motor terminal with the QiTech control software. It demonstrates hardware setup, backend control logic, and a complete user interface for motor control.
Changes:
- Backend implementation (Rust) for motor control with EtherCAT communication
- Frontend UI (React/TypeScript) with real-time state management and control interface
- Comprehensive documentation including hardware wiring diagrams and software architecture
Reviewed changes
Copilot reviewed 16 out of 26 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| machines/src/motor_test_machine/*.rs | Complete backend implementation for motor control, API, and hardware initialization |
| machines/src/registry.rs | Registers the new MotorTestMachine type |
| machines/src/lib.rs | Adds machine constant definition |
| electron/src/machines/motor_test_machine/*.ts(x) | Frontend components for motor control UI and state management |
| electron/src/machines/properties.ts | Machine configuration with device roles |
| electron/src/routes/routes.tsx | Routing setup for motor test pages |
| ethercat-hal/src/devices/el7031_0030/mod.rs | Minor formatting fix |
| docs/developer-docs/minimal-example-el7031-motor.md | Complete tutorial with hardware wiring and software setup |
| docs/developer-docs/getting-started.md | Documentation index update |
| docs/assets/*.png | Hardware setup and UI screenshots |
| .gitignore | Added .idea/ IDE folder exclusion |
58bed6e to
6892f75
Compare
minimal example motor of beckhoff ethercat 7031 0030 + ui